ADD basic playlist support + youtube playlist support#2
Merged
theScrabi merged 2 commits intoTeamNewPipe:masterfrom Mar 21, 2017
Merged
ADD basic playlist support + youtube playlist support#2theScrabi merged 2 commits intoTeamNewPipe:masterfrom
theScrabi merged 2 commits intoTeamNewPipe:masterfrom
Conversation
Member
|
The unit tests are still part of the NewPipe app itself. Nice work. :) |
theScrabi
reviewed
Mar 20, 2017
| public abstract SearchEngine getSearchEngineInstance(); | ||
| public abstract UrlIdHandler getStreamUrlIdHandlerInstance(); | ||
| public abstract UrlIdHandler getChannelUrlIdHandlerInstance(); | ||
| public abstract UrlIdHandler getPlayListUrlIdHandlerInstance(); |
Contributor
Author
|
Ok, It's fixed :) |
Member
|
Ow good question, I did it using the command line. |
Member
|
I've updated the extractor repository. |
Contributor
Author
|
I found, after clone the repos, we just need to tape in command line : And then in AndroidStudio define in the git config the submodule : |
Member
|
ah alright |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I begin the refactor of my previous pull request : TeamNewPipe/NewPipe#377
To avoid the same problem as previously encountered (to big code base change), I begin to submit multiple small pull request.
To avoid the same problem as previously encountered, I will send the code by multiple small pull request.
So here the code for import an external playlist in the core extractor app.
I made a unit test but I didn't found how to commit it in the core part.
So i made a gist for store it : https://gist.github.com/BlenderViking/c73c6776580ed661f78f6b0739a66e73